Improved field number type checking; correct bad usage detected #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
reviewed
Sep 28, 2023
src/ancrec.h
Outdated
Comment on lines
51
to
62
| #if 0 | ||
| // unsuccessful experiment re general fn type check, 8-2023 | ||
| template <typename T> struct FLDNUM | ||
| { FLDNUM(T _fn) | ||
| { | ||
| static_assert(std::is_same<int, T>::value); | ||
| fn = _fn; | ||
| } | ||
| int fn; | ||
| }; | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
Doest this need to be kept? If it has promise, maybe it can be moved to an issue instead?
Contributor
Author
There was a problem hiding this comment.
Agree, I will delete.
nealkruis
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
64-bit development found an instance of IsSet( record-member) where IsSet( record-member-field-number) was intended.
This PR includes several changes to field status access and testing functions to check that the fn (field number) is an integer. With this, the original offending error was detected along with several more. All have been fixed.
A more robust fix would be to define a type for field number. An issue has been added.
No results changes. No regression test changes. No documentation changes.